On 5/20/21 10:42 AM, Markus Armbruster wrote:
First step is to find out how _end_section() can be called twice in a
row.  It isn't in all of "make check".  Hmm.

Ah, maybe not twice in a *row*. It does seem to be called when we have an "empty section" sometimes, which arises from stuff like this:

Extension error:
/home/jsnow/src/qemu/docs/../qga/qapi-schema.json:1143:1: ending a totally empty section

## # @GuestExec: # @pid: pid of child process in guest OS # # Since: 2.5 ##
{ 'struct': 'GuestExec',
  'data': { 'pid': 'int'} }

Without the newline there, it seems to get confused. There's a few like this that could be fixed, but then some of the test cases break too.

No appetite for barking up this tree right now.

Can I fix the commit message and leave the patch in place? Maybe with a #FIXME comment nearby?

--js


Reply via email to