On 18/05/21 12:57, Markus Armbruster wrote:
Paolo Bonzini <pbonz...@redhat.com> writes:
On 18/05/21 10:54, Markus Armbruster wrote:
Paolo Bonzini <pbonz...@redhat.com> writes:
These headers are also included from softmmu/vl.c, so they should be
in include/. Removing qemu-options-wrapper.h, since elsewhere
we include "template" headers directly and #define the parameters in
the including file, and move qemu-options.h to include/.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
---
qemu-options.h => include/qemu/qemu-options.h | 9 ++++-
os-posix.c | 2 +-
os-win32.c | 1 -
qemu-options-wrapper.h | 40 -------------------
qemu-options.hx | 4 ++
softmmu/vl.c | 24 ++++++++---
6 files changed, 31 insertions(+), 49 deletions(-)
rename qemu-options.h => include/qemu/qemu-options.h (88%)
delete mode 100644 qemu-options-wrapper.h
Much nicer without qemu-options-wrapper.h.
I'd be tempted to rename qemu-options.def while there (what's .def?),
but that's up to you.
Reviewed-by: Markus Armbruster <arm...@redhat.com>
I was tempted too, but qemu-options.h is already taken (well,
qemu/qemu-options.h) and I didn't have any good ideas about the name.
qemu-options.inc?
Or .h.inc, in which case it might make sense to rename other files
generated from HXTOOL.
Paolo
