On 5/16/21 4:01 PM, Richard Henderson wrote:
> On 5/15/21 5:42 AM, Philippe Mathieu-Daudé wrote:
>> + qemu_log("0x%08" PRIxPTR ": .quad 0x%0*" TCG_PRIlx
>> "\n",
>> + (uintptr_t)&rx_data_gen_ptr[i],
>> + 2 * sizeof(tcg_target_ulong),
>> rx_data_gen_ptr[i]);
>
> This doesn't quite work, because
>
>
>> ../qemu/accel/tcg/translate-all.c:2045:26: error: field width
>> specifier ‘*’ expects argument of type ‘int’, but argument 3 has type
>> ‘long unsigned int’ [-Werror=format=]
>> 2045 | qemu_log("0x%08" PRIxPTR ": .quad 0x%0*"
>> TCG_PRIlx "\n",
>> | ^~~~~~~
>> 2046 | (uintptr_t)&rx_data_gen_ptr[i],
>> 2047 | 2 * sizeof(tcg_target_ulong),
>> rx_data_gen_ptr[i]);
>> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> | |
>> | long unsigned int
>
>
> However, I also noticed that we shouldn't be printing ".quad" for 32-bit
> hosts either. So I'll just split this into two separate qemu_log
> invocations, based on sizeof(tcg_target_ulong).
Thanks :)
