On Sun, May 16, 2021 at 8:42 PM Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > On 5/16/21 2:50 AM, Bin Meng wrote: > > On Sun, May 16, 2021 at 1:33 AM Philippe Mathieu-Daudé > > <phi...@redhat.com> wrote: > >> > >> On 5/14/21 5:02 AM, Bin Meng wrote: > >>> On Fri, May 14, 2021 at 12:53 AM Philippe Mathieu-Daudé > >>> <phi...@redhat.com> wrote: > >>>> > >>>> Per the kconfig.rst: > >>>> > >>>> A device should be listed [...] ``imply`` if (depending on > >>>> the QEMU command line) the board may or may not be started > >>>> without it. > >>>> > >>>> This is the case with the NVDIMM device (it is certainly possible > >>>> to start a machine without NVDIMM) , so use the 'imply' weak > >>>> reverse dependency to select the symbol. > >>>> > >>>> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > >>>> --- > >>>> default-configs/devices/ppc64-softmmu.mak | 1 - > >>>> hw/arm/Kconfig | 1 + > >>>> hw/i386/Kconfig | 1 + > >>>> hw/mem/Kconfig | 2 -- > >>>> hw/ppc/Kconfig | 1 + > >>>> 5 files changed, 3 insertions(+), 3 deletions(-) > >>>> > >>>> diff --git a/default-configs/devices/ppc64-softmmu.mak > >>>> b/default-configs/devices/ppc64-softmmu.mak > >>>> index ae0841fa3a1..cca52665d90 100644 > >>>> --- a/default-configs/devices/ppc64-softmmu.mak > >>>> +++ b/default-configs/devices/ppc64-softmmu.mak > >>>> @@ -8,4 +8,3 @@ CONFIG_POWERNV=y > >>>> > >>>> # For pSeries > >>>> CONFIG_PSERIES=y > >>>> -CONFIG_NVDIMM=y > >>> > >>> I think only removing this one makes sense. I fail to see any > >>> difference of other changes in this patch. > >> > >> See below "depends on (PC || PSERIES || ARM_VIRT)" > > > > Yes, I saw that. This change does not make any difference compared to > > "depends on" > > No, there is no logical change indeed. Simply IIUC the documentation > "imply" is the preferred form.
Okay, per the documentation "imply" is the preferred way over "default y && depends on". Reviewed-by: Bin Meng <bmeng...@gmail.com>
