On 5/16/21 3:21 AM, Richard Henderson wrote:
> On 5/3/21 4:50 PM, Philippe Mathieu-Daudé wrote:
>> Hi Richard,
>>
>> On 5/3/21 1:57 AM, Richard Henderson wrote:
>>> Signed-off-by: Richard Henderson<richard.hender...@linaro.org>
>>> ---
>>> tcg/internal.h | 5 +++++
>>> tcg/tcg.c | 5 ++---
>>> 2 files changed, 7 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/tcg/internal.h b/tcg/internal.h
>>> index c2d5e9c42f..cd128e2a83 100644
>>> --- a/tcg/internal.h
>>> +++ b/tcg/internal.h
>>> @@ -32,6 +32,11 @@ typedef struct TCGHelperInfo {
>>> unsigned typemask;
>>> } TCGHelperInfo;
>>> +static inline void *tcg_call_func(TCGOp *op)
>>> +{
>>> + return (void *)(uintptr_t)op->args[TCGOP_CALLO(op) +
>>> TCGOP_CALLI(op)];
>> Why not return tcg_insn_unit* type?
>
> That's a fairly tcg code generation type -- this is used for more than
> that. I think it's more natural to use void* when we don't know what
> the real type.
OK.
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
