On Tue, May 11, 2021 at 04:18:54PM +0200, Thomas Huth wrote: > On 11/05/2021 15.26, Daniel P. Berrangé wrote: > > Several distros have been dropped since the last time we bumped the > > minimum required CLang version. > [...] > > -# if __clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 4) > > -# error You need at least Clang v3.4 to compile QEMU > > +# if __clang_major__ < 7 || (__clang_major__ == 7 && __clang_minor__ < 0) > > __clang_minor__ < 0 is very unlikely ... I think you could drop the part > after the "||".
True, though it might be desirable to keep it as a placeholder for when we next bump the min version and have a non-zero minor digit. > > Anyway: > Reviewed-by: Thomas Huth <th...@redhat.com> > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
