Hi Zoltan, On 5/11/21 1:28 PM, BALATON Zoltan wrote: > On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote: >> The motivation behind this series is to remove the >> isa_get_irq(NULL) call to simplify the ISA generic model. >> >> Since v1: >> - rebased on top of remotes/dg-gitlab/tags/ppc-for-6.1-20210504 > > I'll try to have a look at these later but some notes: The pegasos2 > changes are now in master so if this was before that maybe rebasing on > master is now enough.
This is what this series does, simply rebase on top of your merged patches. > However I wonder if any changes to pegasos2.c is > needed due to changed init of the chip model or is that only affecting > 82c686b? There is no change in 'init' in this series, it is only QOM boilerplate code churn, no logical change intended. > Please also note that pegasos2 is not enabled by default due to > needing undistributable firmware ROM so to test it you need to enable it > in default-configs/devices/ppc-softmmu.mak I remember you said you were mostly interested in the VT8231, not the VT82C686. This series only QOM'ify the latter. What is your idea? Send the firmware off-list and explain how the OS works and how (what) to test? Regards, Phil. >> Philippe Mathieu-Daudé (6): >> hw/isa/vt82c686: Name output IRQ as 'intr' >> hw/isa/vt82c686: Simplify removing unuseful qemu_allocate_irqs() call >> hw/isa/vt82c686: Let ISA function expose ISA IRQs >> hw/ide/via: Replace magic 2 value by ARRAY_SIZE / MAX_IDE_DEVS >> hw/ide/via: Connect IDE function output IRQs to the ISA function input >> hw/southbridge/vt82c686: Introduce VT82C686B_SOUTHBRIDGE
