On 4/30/21 12:35 PM, Bruno Larsen (billionai) wrote:
Moved all SPR read/write callback, and some related functions, to a
new file specific for it. These callbacks are TCG only, so separating
them is required to support the build flag disable-tcg.

Making the spr_noaccess function not static, and moving the define to
internal.h is required, otherwise the project doesn't build

Why is that? You're moving the code to a different file, but then including that file back into the same translation unit. There should be no change in which symbols appear in which object file.

I think that the spr_noaccess move might be required by patch 7, but that's something different.


r~

Reply via email to