Re: [PATCH v2 07/15] linux-user/s390x: Use tswap_sigset in setup_rt_frame

[David Hildenbrand]

On 28.04.21 21:34, Richard Henderson wrote:

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
  linux-user/s390x/signal.c | 6 +-----
  1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c
index f8515dd332..4dde55d4d5 100644
--- a/linux-user/s390x/signal.c
+++ b/linux-user/s390x/signal.c
@@ -182,7 +182,6 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
                      target_siginfo_t *info,
                      target_sigset_t *set, CPUS390XState *env)
  {
-    int i;
      rt_sigframe *frame;
      abi_ulong frame_addr;

@@ -199,10 +198,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,

      __put_user((abi_ulong)0, (abi_ulong *)&frame->uc.tuc_link);
      target_save_altstack(&frame->uc.tuc_stack, env);
      save_sigregs(env, &frame->uc.tuc_mcontext);
-    for (i = 0; i < TARGET_NSIG_WORDS; i++) {
-        __put_user((abi_ulong)set->sig[i],
-                   (abi_ulong *)&frame->uc.tuc_sigmask.sig[i]);
-    }
+    tswap_sigset(&frame->uc.tuc_sigmask, set);

/* Set up to return from userspace. If provided, use a stub

         already in userspace.  */

Reviewed-by: David Hildenbrand <da...@redhat.com>

--
Thanks,

David / dhildenb