On 4/28/21 9:24 PM, Richard Henderson wrote: > On 4/28/21 10:56 AM, Philippe Mathieu-Daudé wrote: >> Are you suggesting to remove the 'if have_block' check? This makes build >> a the files pointlessly for user-mode-only builds... > > But since the objects are not included in the binary, I don't care. > > The build system is already too complex, and building a couple of extra > small files makes only milliseconds of difference.
Maybe for libqemuutil.a (this does make a difference with the Python QAPI generated files - another series). I'll wait if we get to a consensus about what exactly is virtiofsd, then revisit this series. Thanks! Phil.