On Wed, Apr 28, 2021 at 4:29 PM Connor Kuehl <cku...@redhat.com> wrote:
> On 4/28/21 9:13 AM, Mahmoud Mandour wrote: > >> I am not entirely sure if this is true. The error message before this > >> patch is applied is: > >> > >> ../tools/meson.build:12:6: ERROR: Problem encountered: virtiofsd > >> requires libcap-ng-devel and seccomp-devel > >> > >> From what I know about virtiofsd, I know it definitely depends on those > >> two things. > >> > >> Is it possible that the error here is that the top-level meson.build is > >> not properly collecting the seccomp and libcap-ng dependencies if the > >> configure invocation doesn't require a system emulation target? > > I also thought that this is the case since I also specifically get this > > error message > > if I enable virtiofsd and specify a target list with only Linux-user > > targets while nothing > > in tools/meson.build specifies so. But I think that even if it correctly > > managed the > > dependencies it would include and build virtiofsd unnecessarily and > that's > > not what we want(?) > > I think that's exactly what we want for the default case because > virtiofsd is enabled by default (../configure --help). Even if the virtiofsd dependencies are satisfied, if one doesn't want to > build virtiofsd, they can pass --disable-virtiofsd to the configure > invocation. > > Connor > > That makes sense, I now understand. Thank you. Mahmoud
