On Sat, 24 Apr 2021 16:53:13 +0200 Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
> Instead of having all TYPE_CCW_DEVICE children set the bus type to > TYPE_VIRTUAL_CSS_BUS, do it once in the abstract parent. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > RFC because I don't know these devices, maybe there is a reason > for setting the bus type in the children (but it should be documented > IMO). We just missed moving the setup from the virtio-ccw device to the ccw device when we introduced the latter; this is a nice cleanup. > --- > hw/s390x/ccw-device.h | 1 + > hw/s390x/3270-ccw.c | 1 - > hw/s390x/ccw-device.c | 1 + > hw/s390x/s390-ccw.c | 2 -- > hw/s390x/virtio-ccw.c | 1 - > 5 files changed, 2 insertions(+), 4 deletions(-) Thanks, applied.
