Hi,

On 4/15/21 6:51 PM, Cleber Rosa wrote:
The test contains methods for the proper log of test related
information.  Let's use that and remove the print and the unused
logging import.

Reference: 
https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log
Signed-off-by: Cleber Rosa <cr...@redhat.com>
---
  tests/acceptance/cpu_queries.py | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py
index 293dccb89a..cc9e380cc7 100644
--- a/tests/acceptance/cpu_queries.py
+++ b/tests/acceptance/cpu_queries.py
@@ -8,8 +8,6 @@
  # This work is licensed under the terms of the GNU GPL, version 2 or
  # later.  See the COPYING file in the top-level directory.
-import logging
-
  from avocado_qemu import Test
class QueryCPUModelExpansion(Test):
@@ -27,7 +25,7 @@ def test(self):
cpus = self.vm.command('query-cpu-definitions')
          for c in cpus:
-            print(repr(c))
+            self.log.info("Checking CPU: %s", c)
              self.assertNotIn('', c['unavailable-features'], c['name'])
for c in cpus:

While you are here, maybe merge the two `for c in cpus` loops? :D

Anyway,

Reviewed-by: Wainer dos Santos Moschetta <waine...@redhat.com>



Reply via email to