On 4/18/21 9:52 PM, Richard Henderson wrote: > On 4/18/21 9:31 AM, Philippe Mathieu-Daudé wrote: >> Move helper_cache() to tcg/sysemu/special_helper.c. >> >> The CACHE opcode is privileged and is not accessible in user >> emulation. However we get a link failure when restricting the >> symbol to sysemu. For now, add a stub to satisfy linking, which >> abort if ever called. >> >> Signed-off-by: Philippe Mathieu-Daudé<f4...@amsat.org> >> --- >> target/mips/op_helper.c | 35 ------------------------- >> target/mips/tcg/sysemu/special_helper.c | 33 +++++++++++++++++++++++ >> target/mips/tcg/user/stubs.c | 29 ++++++++++++++++++++ >> target/mips/tcg/user/meson.build | 1 + >> 4 files changed, 63 insertions(+), 35 deletions(-) >> create mode 100644 target/mips/tcg/user/stubs.c > > You could add a different stub to translate.c instead. See > > https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg08595.html
Great! I think STUB_HELPER() belong to include/exec/helper-*.h. Thanks, Phil.
