On Fri, 16 Apr 2021 at 17:28, Paolo Bonzini <pbonz...@redhat.com> wrote: > > On 16/04/21 15:55, Peter Maydell wrote: > > Hi; this patchseries is: > > (1) a respin of Paolo's patches, with the review issue Dan > > noticed fixed (ie handle arm-a64.cc too) > > (2) a copy of my "osdep.h: Move system includes to top" patch > > (3) some new patches which try to more comprehensively address > > the extern "C" issue > > > > I've marked this "for-6.0?", but more specifically: > > * I think patches 1 and 2 should go in if we do an rc4 > > (and maybe we should do an rc4 given various things that > > have appeared that aren't individually rc4-worthy) > > * patches 3-6 are definitely 6.1 material
> > Patches 1, 2 and 3 have been reviewed (I kept Dan's r-by on > > patch 1 since the change to it is just fixing the thing he > > noticed). Further review, and opinions on the 6.0-ness, whether > > we should do an rc4, etc, appreciated. > > I think at least 1-3 are 6.0 material because build on a supported > distro (Fedora 34, due for release on April 27) is broken right now. We don't support not-yet-released distros, because there's no way to do that: they might always spring new surprises on us that we don't have time to react to. But I agree that the weight of stuff we've built up justifies an rc4. Is patch 3 also required? I thought 1 and 2 would suffice, but I don't have a system which has the newer glib. -- PMM