On Fri, 16 Apr 2021 at 17:25, Paolo Bonzini <pbonz...@redhat.com> wrote: > > On 16/04/21 15:55, Peter Maydell wrote: > > #ifdef _WIN32 > > #include "sysemu/os-win32.h" > > #endif > > @@ -143,6 +139,10 @@ extern "C" { > > #include "sysemu/os-posix.h" > > #endif > > > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > #include "qemu/typedefs.h" > > > > /* > > diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h > > index 629c8c648b7..2edf33658a4 100644 > > --- a/include/sysemu/os-posix.h > > +++ b/include/sysemu/os-posix.h > > @@ -38,6 +38,10 @@ > > #include <sys/sysmacros.h> > > #endif > > > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > include/sysemu/ is also the wrong directory to have these headers, which > probably should be split into a qemu/osdep-{win32,posix}.h part and an > actual sysemu/os-{win32,posix}.h part. But this is good enough for now.
Yeah, I thought as I was writing this that it was odd that these are in sysemu/ but osdep itself is in qemu/... thanks -- PMM