On Tue, Apr 06, 2021 at 09:05:58PM +0200, Igor Mammedov wrote: > On Fri, 02 Apr 2021 19:40:03 +0200 > Vincent Bernat <vinc...@bernat.ch> wrote: > > > ❦ 1 avril 2021 23:07 +02, Vincent Bernat: > > > > >>> This can be invoked with: > > >>> > > >>> $QEMU -netdev user,id=internet > > >>> -device > > >>> virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \ > > >>> -smbios type=41,designation='Onboard > > >>> LAN',instance=1,kind=ethernet,pcidev=internet-dev > > >> > > >> an ACPI alternative was merged recently (current master). > > >> assigning 'designation=' wasn't implemented there, but important part > > >> of giving users control over PCI devices 'eno' index is implemented. > > >> > > >> When I looked into the issue, smbios way was a bit over-kill for the task > > >> and didn't really work if hotplug were used. > > >> > > >> See, for example how to use new feature: > > >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg794164.html > > > > > > It seems simpler this way. I don't think my patch is needed then. > > > > Well, after thinking a bit, if the patch is good enough, maybe it can > > still be merged. It is fairly generic and it adds the ability to set the > > name of the card. It's not as convenient as using acpi-index, but I > > could add a note about acpi-index in the documentation to let people > > know they may prefer the simpler acpi-index? > > Patch looks fine to me. > Can you fix TODO item in it (segment_group_number) on next respin, pls?
One advantage of smbios is that it supports multifunction devices. So there's that. > Also QEMU now is in soft-freeze, so only bug fixes got merged, > it's better to ping Michael after 6.0 is released so patch won't get lost.
