Patchew URL: https://patchew.org/QEMU/20210328205726.1330291-1-vinc...@bernat.ch/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210328205726.1330291-1-vinc...@bernat.ch Subject: [RFC v1] hw/smbios: support for type 41 (onboard devices extended information) === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210328205726.1330291-1-vinc...@bernat.ch -> patchew/20210328205726.1330291-1-vinc...@bernat.ch Switched to a new branch 'test' e30795d hw/smbios: support for type 41 (onboard devices extended information) === OUTPUT BEGIN === ERROR: do not use assignment in if condition #175: FILE: hw/smbios/smbios.c:1309: + if ((t = calloc(1, sizeof(struct type41_instance))) == NULL) { WARNING: line over 80 characters #205: FILE: hw/smbios/smbios.c:1339: + t->pci.device = ((uint8_t)pdevice << 3) + ((uint8_t)pfunction & 0x7); total: 1 errors, 1 warnings, 183 lines checked Commit e30795d491a0 (hw/smbios: support for type 41 (onboard devices extended information)) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210328205726.1330291-1-vinc...@bernat.ch/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
