On Fri, Mar 12, 2021 at 05:07:36PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This series adds 2 new QAPI events, DEVICE_NOT_DELETED and > DEVICE_UNPLUG_ERROR. They were (and are still being) discussed in [1]. > > Patches 1 and 3 are independent of the ppc patches and can be applied > separately. Patches 2 and 4 are based on David's ppc-for-6.0 branch and > are dependent on the QAPI patches.
Implementation looks fine, but I think there's a bit more to discuss
before we can apply.
I think it would make sense to re-order this and put UNPLUG_ERROR
first. Its semantics are clearer, and I think there's a stronger case
for it.
I'm a bit less sold on DEVICE_NOT_DELETED, after consideration. Does
it really tell the user/management anything useful beyond what
receiving neither a DEVICE_DELETED nor a DEVICE_UNPLUG_ERROR does?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
