Philippe Mathieu-Daudé <phi...@redhat.com> writes:
> Hi Alex, > > On 3/17/21 8:22 AM, Alex Bennée wrote: >> From: Richard Henderson <richard.hender...@linaro.org> >> >> Once we've parsed the fractional value, extract it into an integral >> 64-bit fraction. Perform the scaling with integer arithmetic, and >> simplify the overflow detection. >> >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> Signed-off-by: Richard Henderson <richard.hender...@linaro.org> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org> >> Message-Id: <20210315185117.1986240-2-richard.hender...@linaro.org> > > Something is odd with your tooling, the '---' separator is missing. Surely that's only when you have bellow the line comments? b4 strips then when applying series. > > The covers' tag is OK although. > >> >> diff --git a/tests/unit/test-cutils.c b/tests/unit/test-cutils.c >> index bad3a60993..e025b54c05 100644 >> --- a/tests/unit/test-cutils.c >> +++ b/tests/unit/test-cutils.c >> @@ -2128,7 +2128,7 @@ static void test_qemu_strtosz_float(void) >> str = "12.345M"; >> err = qemu_strtosz(str, &endptr, &res); >> g_assert_cmpint(err, ==, 0); >> - g_assert_cmpint(res, ==, (uint64_t) (12.345 * MiB)); >> + g_assert_cmpint(res, ==, (uint64_t) (12.345 * MiB + 0.5)); >> g_assert(endptr == str + 7); >> } -- Alex Bennée
