Patchew URL: https://patchew.org/QEMU/20210315103209.20870-1-akihiko.od...@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210315103209.20870-1-akihiko.od...@gmail.com Subject: [PATCH] net/macos: implement vmnet-based netdev === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210315101352.152888-1-mreza...@redhat.com -> patchew/20210315101352.152888-1-mreza...@redhat.com * [new tag] patchew/20210315103209.20870-1-akihiko.od...@gmail.com -> patchew/20210315103209.20870-1-akihiko.od...@gmail.com Switched to a new branch 'test' 4ceb242 net/macos: implement vmnet-based netdev === OUTPUT BEGIN === Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #144: new file mode 100644 ERROR: externs should be avoided in .c files #178: FILE: net/vmnet-macos.c:30: +int net_init_vmnet_macos(const Netdev *netdev, const char *name, WARNING: architecture specific defines should be avoided #203: FILE: net/vmnet-macos.c:55: +#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 110000 ERROR: spaces required around that '^' (ctx:ExV) #287: FILE: net/vmnet-macos.c:139: + ^bool(size_t index, xpc_object_t _Nonnull value) { ^ ERROR: spaces required around that '^' (ctx:ExV) #300: FILE: net/vmnet-macos.c:152: + ^bool(size_t index, xpc_object_t _Nonnull value) { ^ WARNING: line over 80 characters #385: FILE: net/vmnet-macos.c:237: + xpc_object_t iface_desc = _construct_vmnet_interface_description(vmnet_opts); ERROR: spaces required around that '^' (ctx:ExV) #419: FILE: net/vmnet-macos.c:271: + ^(vmnet_return_t status, xpc_object_t _Nullable interface_param) { ^ ERROR: spaces required around that '^' (ctx:ExV) #500: FILE: net/vmnet-macos.c:352: + ^(interface_event_t event_mask, xpc_object_t _Nonnull event) { ^ WARNING: Block comments use a leading /* on a separate line #538: FILE: net/vmnet-macos.c:390: + /* Dispatch this block to a global queue instead of the main queue, ERROR: spaces required around that '^' (ctx:ExV) #545: FILE: net/vmnet-macos.c:397: + ^{ ^ total: 6 errors, 4 warnings, 654 lines checked Commit 4ceb242f281c (net/macos: implement vmnet-based netdev) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210315103209.20870-1-akihiko.od...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com