On 3/15/21 10:18 AM, Philippe Mathieu-Daudé wrote: > On 3/15/21 10:17 AM, Philippe Mathieu-Daudé wrote: >> On 3/15/21 8:57 AM, Bin Meng wrote: >>> This adds a flag in NetClientState, so that a net client can tell >>> its peer that the packets do not need to be padded to the minimum >>> size of an Ethernet frame (60 bytes) before sending to it. >>> >>> Signed-off-by: Bin Meng <bmeng...@gmail.com> >>> --- >>> >>> include/net/net.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/include/net/net.h b/include/net/net.h >>> index 919facaad2..6fab1f83f5 100644 >>> --- a/include/net/net.h >>> +++ b/include/net/net.h >>> @@ -100,6 +100,7 @@ struct NetClientState { >>> int vring_enable; >>> int vnet_hdr_len; >>> bool is_netdev; >>> + bool do_not_pad;
Maybe 'do_not_pad_to_min_eth_frame_len' to avoid wondering what padding is it. >>> QTAILQ_HEAD(, NetFilterState) filters; >>> }; >> >> This is a bit pointless without the next patch, why >> not squash it there? > > Ah one is SLiRP and the other is tap. OK then. > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >