> -----Original Message-----
> From: Richard Henderson <richard.hender...@linaro.org>
> Sent: Sunday, February 14, 2021 5:41 PM
> To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu;
> a...@rev.ng; Brian Cain <bc...@quicinc.com>
> Subject: Re: [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes
>
> On 2/7/21 9:46 PM, Taylor Simpson wrote:
> > + } else if ((itype == ICLASS_V2LDST) && (GET_ATTRIB(opcode,
> A_STORE))) {
> > + return SLOTS_01;
> > + } else if ((itype == ICLASS_V2LDST) && (!GET_ATTRIB(opcode,
> A_STORE))) {
> > + return SLOTS_01;
>
> What's the point of this? Between the two all ICLASS_V2LDST use SLOTS_01.
> Why
> can't it be done in
>
> > + return iclass_info[itype];
Good catch - I'll eliminate the unnecessary checks.
