On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
+#define AVR_GPIO_COUNT 8
+
+struct AVRGPIOState {
+ /*< private >*/
+ SysBusDevice parent_obj;
+
+ /*< public >*/
+ MemoryRegion mmio;
+
+ struct {
+ uint8_t pin;
+ uint8_t ddr;
+ uint8_t port;
+ } reg;
+
+ /* PORTx data changed IRQs */
+ qemu_irq out[8u];
AVR_GPIO_COUNT?
Can we drop all the useless 'u' suffixes from all over?
+ gpio->reg.pin = 0u;
+ gpio->reg.ddr = 0u;
+ gpio->reg.port = 0u;
...
+ uint8_t cur_port_pin_val = cur_port_val & 0x01u;
+ uint8_t cur_ddr_pin_val = cur_ddr_val & 0x01u;
+ uint8_t new_port_pin_val = value & 0x01u;
...
+ cur_port_val >>= 1u;
+ cur_ddr_val >>= 1u;
+ value >>= 1u;
etc.
Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
