On Wed, Mar 03, 2021 at 10:20:20PM +0900, Akihiko Odaki wrote:
> 2021年3月3日(水) 18:27 Gerd Hoffmann <kra...@redhat.com>:
> >
> > Hi,
> >
> > > status = coreaudio_get_voice(&core->outputDeviceID);
> > > if (status != kAudioHardwareNoError) {
> > > - coreaudio_logerr2 (status, typ,
> > > - "Could not get default output Device\n");
> > > - return -1;
> > > + coreaudio_playback_logerr (status,
> > > + "Could not get default output
> > > Device\n");
> > > + return status;
> >
> > This "pass status code to caller" change can and should be splitted to a
> > separate patch.
> >
> > Likewise with the logging changes.
> >
> > That makes the patch with the actual functional change to deal with the
> > device changes smaller and easier to review.
> >
> > thanks,
> > Gerd
> >
>
> Actually the code was extracted from coreaudio_init_out to
> init_out_device in this patch.
It is likewise good practice to handle such refactorings as separate
patch, i.e. have a patch which reorganizes the code (in this case move
code to the new init_out_device() function) without functional change,
then go add the new handle_voice_change which fixes the actual issue
in the next patch. Finally send the two (or more) changes as patch
series.
take care,
Gerd
