On Mar 8 18:53, Peter Maydell wrote: > On Mon, 8 Mar 2021 at 18:46, Klaus Jensen <i...@irrelevant.dk> wrote: > > > > On Mar 8 19:32, Paolo Bonzini wrote: > > > On 08/03/21 13:22, Klaus Jensen wrote: > > > > > > > > This patch introduced a simple nvme-subsys device model. The subsystem > > > > will be prepared with subsystem NQN with <subsys_id> provided in > > > > nvme-subsys device: > > > > > > > > ex) -device nvme-subsys,id=subsys0: nqn.2019-08.org.qemu:subsys0 > > > > > > Hi Klaus, sorry for not spotting this before. In the SCSI subsystem we > > > moved away from using id as guest-visible data. Keeping it as a default > > > is > > > fine I guess, but would it be possible to add an nqn property to > > > nvme-subsys > > > and use it if it is present instead of the id? > > > > > > Thanks, > > > > > > Paolo > > > > > > > Hi Paolo, > > > > Thanks for pointing this out! Absolutely - we have no specific reason to > > use 'id', so we can just change it completely to use 'nqn'. > > > > Peter, you want this in a v2 or did you already start integration of > > this PR? > > I haven't yet started working on this PR so if the change is trivial > feel free to roll a v2. >
Thanks, I'll do that!
signature.asc
Description: PGP signature
