On 3/5/2021 12:18 PM, Paolo Bonzini wrote:


Ok, so let's go with your patch for now.  Independently we could change libslirp to:

- add a separate callback (timer_new_v2?) in SlirpCb.  If it is set, we use it and pass an enum instead of the SlirpTimerCb cb.

- add a function slirp_timer_expired(enum SlirpTimerId timer_id, void *cb_opaque) that does the indirection but without passing around an arbitrary function pointer.

In 6.1 we will update the internal libslirp to a version that supports the new API, through a patch very similar to mine above.  By requiring that new version as the minimum supported one, enabling CFI will be possible even with system slirp.

You can open a slirp merge request at https://gitlab.freedesktop.org/slirp/libslirp.

Hi Paolo,
sounds like a good plan!

I'll start working on this.

Regards,
Daniele

Reply via email to