On 3/8/21 11:48 AM, Philippe Mathieu-Daudé wrote:
> On 2/15/21 5:26 PM, Richard Henderson wrote:
>> On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote:
>>> + if (a->rt == 0) {
>>> + tcg_gen_movi_i64(cpu_gpr[a->rd], 0);
>>> + tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0);
>>> + return true;
>>> + }
>>
>> Is there a good reason not to use gen_load_gpr?
>
> I suppose you meant gen_store_gpr*().
Double checking, we check for $rt, not $rd, right?
>
> We need to check $rt anyway to not do the deposit calls
> if it is non-zero.
>
> As it is mostly code movement, I prefer to keep it as it
> for now, we might improve it later.
>
>>
>> Otherwise,
>> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
>
> Thanks!
>
