On 22/02/2021 17.10, Stefan Hajnoczi wrote:
For some reason memfd never used share=on. vhost-user relies on
mmap(MAP_SHARED) so this seems like a problem, but the tests still run
without it.
Add share=on for consistency and to prevent future bugs in the test.
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
---
tests/qtest/vhost-user-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index 1a5f5313ff..2db98c4920 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -40,7 +40,7 @@
#define QEMU_CMD_MEM " -m %d -object memory-backend-file,id=mem,size=%dM,"
\
"mem-path=%s,share=on -numa node,memdev=mem"
#define QEMU_CMD_MEMFD " -m %d -object
memory-backend-memfd,id=mem,size=%dM," \
- " -numa node,memdev=mem"
+ "share=on -numa node,memdev=mem"
Even if it's not required, it seems to be a good clean up, also with regards
to the lonely comma at the end of the previous line.
Acked-by: Thomas Huth <th...@redhat.com>
I assume this will go through the vhost tree, or do you want me to take this
single patch through my qtest tree?
