Re: [PATCH 2/2] target/tricore: Fix OPC2_32_RRPW_EXTR for width=0

[Richard Henderson]

On 3/5/21 5:26 AM, Bastian Koppelmann wrote:
      case OPC2_32_RRPW_EXTR:
+        if (width == 0) {
+                tcg_gen_movi_tl(cpu_gpr_d[r3], 0);
+                break;
+        }
+
          if (pos + width <= 32) {
-            /* optimize special cases */
+                        /* optimize special cases */
              if ((pos == 0) && (width == 8)) {

Indentation is definitely off, both with the unrelated comment change Phil 
pointed out, and in the new code block.

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~