On Wed, Mar 03, 2021 at 03:51:02PM +0100, Thomas Huth wrote: > On 14/01/2021 14.02, Daniel P. Berrangé wrote: > > This is the fully expanded list of build pre-requisites QEMU can > > conceivably use in any scenario. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > tests/docker/dockerfiles/centos7.docker | 58 +++++++++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > > > diff --git a/tests/docker/dockerfiles/centos7.docker > > b/tests/docker/dockerfiles/centos7.docker > > index 1eb3455144..d2daaae25b 100644 > > --- a/tests/docker/dockerfiles/centos7.docker > > +++ b/tests/docker/dockerfiles/centos7.docker > > @@ -6,37 +6,95 @@ RUN yum -y update > > # Please keep this list sorted alphabetically > > ENV PACKAGES \ > > SDL2-devel \ > > + alsa-lib-devel \ > > + bc \ > > Why is bc suddenly required now?
It is used by acceptance tests / avocado IIUC. Other dockrefiles already have it present, and this is making centos consistent. > > > + brlapi-devel \ > > bzip2 \ > > bzip2-devel \ > > + ca-certificates \ > > + capstone-devel \ > > capstone in Centos 7 is definitely too old - we need >= 4.0 now, and Centos > 7 still uses 3.0 if I've got that right. Possibly, but the goal here is to have a consistent set of packages installed across all dockerfiles. In fact having it installed is good because it will prove that QEMU does the right thing and detect that it needs to use its bundled copy. > > + python3-PyYAML \ > > + python3-numpy \ > > + python3-pillow \ > > + python3-pip \ > > + python3-setuptools \ > > + python3-sphinx \ > > + python3-virtualenv \ > > + python3-wheel \ > > rdma-core-devel \ > > + rpm \ > > Why rpm ? Acceptance tests run rpm2cpio > > > + sed \ > > Do we really need to specify sed separately? Any tool that is used should be listed explicitly, even if it happens to get pulled in indirectly via another dep. > > > snappy-devel \ > > spice-protocol \ > > spice-server-devel \ > > + systemd-devel \ > > + systemtap-sdt-devel \ > > tar \ > > + texinfo \ > > + usbredir-devel \ > > + vim-minimal \ > > vim? Why that? The ubuntu dockerfile had this, so I was trying to make it consistent. I've since removed it though, since others thought the inclusion in ubuntu dockerfile was really a bug. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
