On 2/22/21 10:49 AM, Alex Richardson wrote: > --- > target/riscv/insn_trans/trans_rvh.c.inc | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
Any particular reason? At first I thought this was a macro with a hidden return, but it isn't. I would understand a cleanup like if (check_access(ctx)) { TCGv t0 = tcg_temp_new(); TCGv t1 = tcg_temp_new(); ... where we do not generate the rest of the code if we raised an exception. Alternately, if the nesting seems ugly, if (!check_access(ctx)) { return true; } ... return true; r~