Patchew URL: https://patchew.org/QEMU/20210218172156.25520-1-cfont...@suse.de/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210218172156.25520-1-cfont...@suse.de Subject: [PATCH v20 00/17] i386 cleanup PART 2 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 91416a4..b826fb8 master -> master - [tag update] patchew/1613447214-81951-1-git-send-email-bmeng...@gmail.com -> patchew/1613447214-81951-1-git-send-email-bmeng...@gmail.com - [tag update] patchew/20210218145111.1591763-1-f4...@amsat.org -> patchew/20210218145111.1591763-1-f4...@amsat.org * [new tag] patchew/20210218172156.25520-1-cfont...@suse.de -> patchew/20210218172156.25520-1-cfont...@suse.de Switched to a new branch 'test' 3e701ea i386: move cpu_load_efer into SOFTMMU-only section of cpu.h a4751ee i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU 4b07b36 i386: split off softmmu part of cpu.c e9952da i386: split seg_helper into user-only and softmmu parts 3835405 i386: split svm_helper into softmmu and stub-only user 86e8d84 i386: separate fpu_helper into user and softmmu parts 49d103e i386: split misc helper into user and softmmu parts e6dfb8b i386: move TCG btp_helper into softmmu/ 3310fc0 i386: split tcg excp_helper into softmmu and user parts 170940f i386: split smm helper (softmmu) 6f5ab9e i386: split off softmmu-only functionality in tcg-cpu d4731fd meson: add target_user_arch 1449482 accel-cpu: make cpu_realizefn return a bool 74dc094 target/i386: fix host_cpu_adjust_phys_bits error handling 9b37c1a accel: introduce new accessor functions ef32e49 cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn 21481bf i386: split cpu accelerators from cpu.c, using AccelCPUClass === OUTPUT BEGIN === 1/17 Checking commit 21481bf408a9 (i386: split cpu accelerators from cpu.c, using AccelCPUClass) WARNING: line over 80 characters #1336: FILE: target/i386/tcg/tcg-cpu.c:125: + memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0); total: 0 errors, 1 warnings, 1256 lines checked Patch 1/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/17 Checking commit ef32e49d0f42 (cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn) 3/17 Checking commit 9b37c1a0f12d (accel: introduce new accessor functions) 4/17 Checking commit 74dc094afec3 (target/i386: fix host_cpu_adjust_phys_bits error handling) 5/17 Checking commit 1449482c2949 (accel-cpu: make cpu_realizefn return a bool) 6/17 Checking commit d4731fd1d6fa (meson: add target_user_arch) 7/17 Checking commit 6f5ab9e35b58 (i386: split off softmmu-only functionality in tcg-cpu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 WARNING: line over 80 characters #115: FILE: target/i386/tcg/softmmu/tcg-cpu.c:72: + memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0); total: 0 errors, 2 warnings, 212 lines checked Patch 7/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/17 Checking commit 170940f6d79a (i386: split smm helper (softmmu)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: target/i386/tcg/{ => softmmu}/smm_helper.c | 19 ++----------------- total: 0 errors, 1 warnings, 84 lines checked Patch 8/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/17 Checking commit 3310fc0cfae8 (i386: split tcg excp_helper into softmmu and user parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #598: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #736: FILE: target/i386/tcg/softmmu/excp_helper.c:134: + /* Bits 20-13 provide bits 39-32 of the address, bit 21 is reserved. WARNING: Block comments use a leading /* on a separate line #810: FILE: target/i386/tcg/softmmu/excp_helper.c:208: +/* return value: WARNING: line over 80 characters #911: FILE: target/i386/tcg/softmmu/excp_helper.c:309: + pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) << 3)) & WARNING: Block comments use a leading /* on a separate line #1005: FILE: target/i386/tcg/softmmu/excp_helper.c:403: + /* Bits 20-13 provide bits 39-32 of the address, bit 21 is reserved. WARNING: Block comments use a leading /* on a separate line #1100: FILE: target/i386/tcg/softmmu/excp_helper.c:498: + /* only set write access if already dirty... otherwise wait WARNING: Block comments use * on subsequent lines #1101: FILE: target/i386/tcg/softmmu/excp_helper.c:499: + /* only set write access if already dirty... otherwise wait + for dirty access */ WARNING: Block comments use a trailing */ on a separate line #1101: FILE: target/i386/tcg/softmmu/excp_helper.c:499: + for dirty access */ WARNING: Block comments use a leading /* on a separate line #1114: FILE: target/i386/tcg/softmmu/excp_helper.c:512: + /* Even if 4MB pages, we map only one 4KB page in the cache to WARNING: Block comments use * on subsequent lines #1115: FILE: target/i386/tcg/softmmu/excp_helper.c:513: + /* Even if 4MB pages, we map only one 4KB page in the cache to + avoid filling it too fast */ WARNING: Block comments use a trailing */ on a separate line #1115: FILE: target/i386/tcg/softmmu/excp_helper.c:513: + avoid filling it too fast */ ERROR: braces {} are necessary for all arms of this statement #1129: FILE: target/i386/tcg/softmmu/excp_helper.c:527: + if (is_user) [...] total: 1 errors, 11 warnings, 612 lines checked Patch 9/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/17 Checking commit e6dfb8b80027 (i386: move TCG btp_helper into softmmu/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #363: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #499: FILE: target/i386/tcg/softmmu/bpt_helper.c:132: + /* If nothing is changing except the global/local enable bits, WARNING: Block comments use * on subsequent lines #500: FILE: target/i386/tcg/softmmu/bpt_helper.c:133: + /* If nothing is changing except the global/local enable bits, + then we can make the change more efficient. */ WARNING: Block comments use a trailing */ on a separate line #500: FILE: target/i386/tcg/softmmu/bpt_helper.c:133: + then we can make the change more efficient. */ WARNING: Block comments use a leading /* on a separate line #502: FILE: target/i386/tcg/softmmu/bpt_helper.c:135: + /* Fold the global and local enable bits together into the WARNING: Block comments use * on subsequent lines #503: FILE: target/i386/tcg/softmmu/bpt_helper.c:136: + /* Fold the global and local enable bits together into the + global fields, then xor to show which registers have WARNING: Block comments use a trailing */ on a separate line #504: FILE: target/i386/tcg/softmmu/bpt_helper.c:137: + changed collective enable state. */ total: 0 errors, 7 warnings, 623 lines checked Patch 10/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/17 Checking commit 49d103e1eff7 (i386: split misc helper into user and softmmu parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #526: new file mode 100644 ERROR: switch and case should be at the same indent #819: FILE: target/i386/tcg/softmmu/misc_helper.c:289: + switch ((uint32_t)env->regs[R_ECX]) { [...] + case MSR_IA32_UCODE_REV: total: 1 errors, 1 warnings, 1009 lines checked Patch 11/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/17 Checking commit 86e8d8420ffb (i386: separate fpu_helper into user and softmmu parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #143: new file mode 100644 total: 0 errors, 1 warnings, 219 lines checked Patch 12/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/17 Checking commit 3835405787f4 (i386: split svm_helper into softmmu and stub-only user) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: target/i386/tcg/{ => softmmu}/svm_helper.c | 62 +----------------------- total: 0 errors, 1 warnings, 169 lines checked Patch 13/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/17 Checking commit e9952da7ccbd (i386: split seg_helper into user-only and softmmu parts) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #320: new file mode 100644 ERROR: do not use C99 // comments #347: FILE: target/i386/tcg/seg_helper.h:23: +//#define DEBUG_PCALL WARNING: Block comments use a leading /* on a separate line #620: FILE: target/i386/tcg/user/seg_helper.c:73: + /* Since we emulate only user space, we cannot do more than WARNING: Block comments use * on subsequent lines #621: FILE: target/i386/tcg/user/seg_helper.c:74: + /* Since we emulate only user space, we cannot do more than + exiting the emulation with the suitable exception and error WARNING: Block comments use a trailing */ on a separate line #622: FILE: target/i386/tcg/user/seg_helper.c:75: + code. So update EIP for INT 0x80 and EXCP_SYSCALL. */ WARNING: Block comments use a leading /* on a separate line #633: FILE: target/i386/tcg/user/seg_helper.c:86: + /* if user mode only, we simulate a fake exception WARNING: Block comments use * on subsequent lines #634: FILE: target/i386/tcg/user/seg_helper.c:87: + /* if user mode only, we simulate a fake exception + which will be handled outside the cpu execution WARNING: Block comments use a trailing */ on a separate line #635: FILE: target/i386/tcg/user/seg_helper.c:88: + loop */ total: 1 errors, 7 warnings, 595 lines checked Patch 14/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/17 Checking commit 4b07b3640460 (i386: split off softmmu part of cpu.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #51: FILE: target/i386/cpu-internal.h:30: + /* feature flags names are taken from "Intel Processor Identification and WARNING: Block comments use a leading /* on a separate line #134: FILE: target/i386/cpu-softmmu.c:37: +/* Return a QDict containing keys for all properties that can be included WARNING: Block comments use a leading /* on a separate line #187: FILE: target/i386/cpu-softmmu.c:90: +/* Convert CPU model data from X86CPU object to a property dictionary WARNING: Block comments use a leading /* on a separate line #201: FILE: target/i386/cpu-softmmu.c:104: +/* Convert CPU model data from X86CPU object to a property dictionary WARNING: Block comments use a leading /* on a separate line #217: FILE: target/i386/cpu-softmmu.c:120: + /* "hotplugged" is the only property that is configurable WARNING: Block comments use a leading /* on a separate line #307: FILE: target/i386/cpu-softmmu.c:210: + /* As we don't return every single property, full expansion needs total: 0 errors, 7 warnings, 895 lines checked Patch 15/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/17 Checking commit a4751eec6c42 (i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU) 17/17 Checking commit 3e701ea5b44e (i386: move cpu_load_efer into SOFTMMU-only section of cpu.h) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210218172156.25520-1-cfont...@suse.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
