On Dienstag, 16. Februar 2021 08:15:12 CET Thomas Huth wrote:
> There were recently some patches on the list which had their "From:"
> line mangled like this:
>
> From: qemu_oss--- via <qemu-devel@nongnu.org>
>
> Since our test in the checkpatch.pl script did not trigger here, the
> patches finally also ended up in a pull request, with the wrong author
> set. So let's improve the regular expression to also complain on
> these new patterns, too.
>
> Signed-off-by: Thomas Huth <th...@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e47ad878d8..7f194c842b 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1499,7 +1499,7 @@ sub process {
> $is_patch = 1;
> }
>
> - if ($line =~ /^Author: .*via
> Qemu-devel.*<qemu-devel\@nongnu.org>/) {
> + if ($line =~ /^(Author|From): .* via
> .*<qemu-devel\@nongnu.org>/) {
> ERROR("Author email address is mangled by the mailing
> list\n" .
> $herecurr); }
I would probably generalize the pattern even a bit more:
if ($line =~ /^(Author|From): .*<qemu-devel\@nongnu.org>/) {
Because mailman's precise sender-rewrite prefix changed couple times. But for
now the change above will do as well of course.
Reviewed-by: Christian Schoenebeck <qemu_...@crudebyte.com>
Best regards,
Christian Schoenebeck
