Hi Alistair,
> -----Original Message-----
> From: Alistair Francis <alistai...@gmail.com>
> Sent: Saturday, February 13, 2021 3:38 AM
> To: Sai Pavan Boddu <saip...@xilinx.com>
> Cc: Markus Armbruster <arm...@redhat.com>; Kevin Wolf
> <kw...@redhat.com>; Max Reitz <mre...@redhat.com>; Vladimir Sementsov-
> Ogievskiy <vsement...@virtuozzo.com>; Eric Blake <ebl...@redhat.com>;
> Joel Stanley <j...@jms.id.au>; Cédric Le Goater <c...@kaod.org>; Vincent
> Palatin <vpala...@chromium.org>; Dr. David Alan Gilbert
> <dgilb...@redhat.com>; Thomas Huth <th...@redhat.com>; Stefan Hajnoczi
> <stefa...@redhat.com>; Peter Maydell <peter.mayd...@linaro.org>; Alistair
> Francis <alistair.fran...@wdc.com>; Edgar Iglesias <edg...@xilinx.com>; Luc
> Michel <luc.mic...@greensocs.com>; Paolo Bonzini <pbonz...@redhat.com>;
> Sai Pavan Boddu <saip...@xilinx.com>; qemu-devel@nongnu.org Developers
> <qemu-devel@nongnu.org>; Qemu-block <qemu-bl...@nongnu.org>
> Subject: Re: [RFC PATCH 09/15] sd: emmc: Add support for emmc erase
>
> On Thu, Feb 11, 2021 at 12:19 AM Sai Pavan Boddu
> <sai.pavan.bo...@xilinx.com> wrote:
> >
> > Add CMD35 and CMD36 which sets the erase start and end.
> >
> > Signed-off-by: Sai Pavan Boddu <sai.pavan.bo...@xilinx.com>
> > Signed-off-by: Edgar E. Iglesias <edgar.igles...@xilinx.com>
> > ---
> > hw/sd/sd.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> > index 236f2b8..7aab647 100644
> > --- a/hw/sd/sd.c
> > +++ b/hw/sd/sd.c
> > @@ -1544,6 +1544,7 @@ static sd_rsp_type_t sd_normal_command(SDState
> > *sd, SDRequest req)
> >
> > /* Erase commands (Class 5) */
> > case 32: /* CMD32: ERASE_WR_BLK_START */
> > + case 35:
>
> Can you comment the CMD here?
[Sai Pavan Boddu] Sure I will update this.
Regards,
Sai Pavan
>
> > switch (sd->state) {
> > case sd_transfer_state:
> > sd->erase_start = req.arg; @@ -1555,6 +1556,7 @@ static
> > sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
> > break;
> >
> > case 33: /* CMD33: ERASE_WR_BLK_END */
> > + case 36:
>
> and here?
>
> Alistair
>
> > switch (sd->state) {
> > case sd_transfer_state:
> > sd->erase_end = req.arg;
> > --
> > 2.7.4
> >
> >
