On Mon, 15 Feb 2021 at 12:02, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > On 2/15/21 12:51 PM, Peter Maydell wrote: > > Currently the MPS2 SCC device implements a fixed number of OSCCLK > > values (3). The variant of this device in the MPS3 AN524 board has 6 > > OSCCLK values. Switch to using a PROP_ARRAY, which allows board code > > to specify how large the OSCCLK array should be as well as its > > values. > > > > With a variable-length property array, the SCC no longer specifies > > default values for the OSCCLKs, so we must set them explicitly in the > > board code. This defaults are actually incorrect for the an521 and > > an505; we will correct this bug in a following patch. > > > > This is a migration compatibility break for all the mps boards. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > R-b stands :) > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Yeah, it's down here... > > It would be possible to avoid the compat break, but we've already > > broken compat for the mps boards this release cycle (eg in commit > > eeae0b2bf4e69de2) when we added Clock support to the armsse code, so > > there's no point in trying to keep compat for this change. > > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> ...below the '---' material, because the script I use to add the r-by tags isn't clever enough to figure out that it ought to add them above the '---' line rather than just at the bottom of the commit message. Sorry about that. -- PMM
