Patchew URL: https://patchew.org/QEMU/27dfe8eb-adce-8db4-f28b-c42858b08...@msgid.tls.msk.ru/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 27dfe8eb-adce-8db4-f28b-c42858b08...@msgid.tls.msk.ru Subject: RFC: linux-user: preserving argv[0] of the original binary in context of binfmt-misc === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu eac92d3..f4ceebd master -> master - [tag update] patchew/1610505995-144129-1-git-send-email-lei....@intel.com -> patchew/1610505995-144129-1-git-send-email-lei....@intel.com - [tag update] patchew/20201008043105.21058-1-cheng...@emindsoft.com.cn -> patchew/20201008043105.21058-1-cheng...@emindsoft.com.cn - [tag update] patchew/20201011195001.3219730-1-f4...@amsat.org -> patchew/20201011195001.3219730-1-f4...@amsat.org - [tag update] patchew/20210131061849.12615-1-vfa...@xes-inc.com -> patchew/20210131061849.12615-1-vfa...@xes-inc.com - [tag update] patchew/20210131061948.15990-1-vfa...@xes-inc.com -> patchew/20210131061948.15990-1-vfa...@xes-inc.com - [tag update] patchew/20210201155922.ga18...@ls3530.fritz.box -> patchew/20210201155922.ga18...@ls3530.fritz.box - [tag update] patchew/20210201220551.ga8...@ls3530.fritz.box -> patchew/20210201220551.ga8...@ls3530.fritz.box - [tag update] patchew/20210204153925.2030606-1-ja...@zx2c4.com -> patchew/20210204153925.2030606-1-ja...@zx2c4.com - [tag update] patchew/20210210171537.32932-1-da...@redhat.com -> patchew/20210210171537.32932-1-da...@redhat.com - [tag update] patchew/20210213130325.14781-1-alex.ben...@linaro.org -> patchew/20210213130325.14781-1-alex.ben...@linaro.org * [new tag] patchew/27dfe8eb-adce-8db4-f28b-c42858b08...@msgid.tls.msk.ru -> patchew/27dfe8eb-adce-8db4-f28b-c42858b08...@msgid.tls.msk.ru Switched to a new branch 'test' 53c7840 RFC: linux-user: preserving argv[0] of the original binary in context of binfmt-misc === OUTPUT BEGIN === WARNING: Block comments use a leading /* on a separate line #85: FILE: linux-user/main.c:564: + /* HACK alert. WARNING: line over 80 characters #87: FILE: linux-user/main.c:566: + * we have to know where are we (our own binary), where's the binary being run, WARNING: line over 80 characters #89: FILE: linux-user/main.c:568: + * Only with the P interpreter flag kernel passes all 3 elements as first 3 argv[], WARNING: line over 80 characters #91: FILE: linux-user/main.c:570: + * So we register a special name with binfmt-misc system, a name which ends up WARNING: line over 80 characters #92: FILE: linux-user/main.c:571: + * in "-binfmt-P", and if our argv[0] ends up with that, we assume we were run WARNING: line over 80 characters #96: FILE: linux-user/main.c:575: + strcmp(argv[0] + strlen(argv[0]) - sizeof("binfmt-P"), "-binfmt-P") == 0) { ERROR: line over 90 characters #98: FILE: linux-user/main.c:577: + (void) fprintf(stderr, "qemu: %s has to be run using kernel binfmt-misc subsystem\n", argv[0]); ERROR: Missing Signed-off-by: line(s) total: 2 errors, 6 warnings, 27 lines checked Commit 53c7840551a1 (RFC: linux-user: preserving argv[0] of the original binary in context of binfmt-misc) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/27dfe8eb-adce-8db4-f28b-c42858b08...@msgid.tls.msk.ru/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
