Ciao Paolo, On 2/5/21 9:04 PM, Richard Henderson wrote: > On 2/4/21 6:39 AM, Claudio Fontana wrote: >> +static void hvf_cpu_accel_class_init(ObjectClass *oc, void *data) >> +{ >> + AccelCPUClass *acc = ACCEL_CPU_CLASS(oc); >> + >> + acc->cpu_realizefn = host_cpu_realizefn; >> + acc->cpu_instance_init = hvf_cpu_instance_init; >> +}; > > Watch the stray ; after functions.
Thanks Richard, removed. > Make sure there's a blank line in between functions and file-scope structure > definitions. I'll keep an eye on it, let me know if you see an example in this or other patches. > >> +static const TypeInfo hvf_cpu_accel_type_info = { >> + .name = ACCEL_CPU_NAME("hvf"), >> + >> + .parent = TYPE_ACCEL_CPU, >> + .class_init = hvf_cpu_accel_class_init, >> + .abstract = true, >> +}; >> +static void hvf_cpu_accel_register_types(void) >> +{ >> + type_register_static(&hvf_cpu_accel_type_info); >> +} > > The rest looks ok, but I would like to see other i386 review. Thanks, maybe Paolo could help? It's just code shuffling, but of course a mistake is always possible. Claudio