On 2/9/21 8:57 AM, Paolo Bonzini wrote:
> Because trace_opt_parse always deletes the options it has parsed,
> trace_init_file's call to qemu_find_opts_singleton always
> creates an empty -trace option group. Therefore, the subsequent
> qemu_opt_get(opts, "file") always returns NULL.
>
> To fix this, save the last "-trace file=..." option in a global
> variable and use it later in trace_init_file.
>
> This is similar to what was done before commit 92eecfff32 ("trace:
> remove argument from trace_init_file", 2020-11-11), except contained
> within trace/control.c and without memory leaks.
>
> Fixes: 92eecfff32 ("trace: remove argument from trace_init_file", 2020-11-11)
> Cc: stefa...@redhat.com
> Reported-by: arm...@redhat.com
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> trace/control.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
