On Wed, 3 Feb 2021 at 19:00, Richard Henderson <richard.hender...@linaro.org> wrote: > > Use g2h_untagged in contexts that have no cpu, e.g. the binary > loaders that operate before the primary cpu is created. As a > collolary, target_mmap and friends must use untagged addresses,
"corollary" > since they are used by the loaders. > > Use g2h_untagged on values returned from target_mmap, as the > kernel never applies a tag itself. > > Use g2h_untagged on all pc values. The only current user of > tags, aarch64, removes tags from code addresses upon branch, > so "pc" is always untagged. > > Use g2h with the cpu context on hand whereever possible. "wherever" > > Use g2h_untagged in lock_user, which will be updated soon. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM