On 1/28/21 8:04 AM, Cédric Le Goater wrote: > Hello Bin, > > On 1/28/21 7:43 AM, Bin Meng wrote: >> From: Bin Meng <bin.m...@windriver.com> >> >> These APIs and macros may be referenced by functions that are >> currently before them. Move them ahead a little bit. > > We could also change fprintf() by qemu_log_mask()
Hmm in this case warn_report() maybe, as IIUC QEMU aims to support using smaller block drive (which this model currently rejects), in which case this wouldn't be a GUEST_ERROR. Can be done on top in another patch, since this is pure code movement. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>