On Thu, Feb 04, 2021 at 12:04:07AM -0800, isaku.yamah...@gmail.com wrote: > From: Isaku Yamahata <isaku.yamah...@intel.com> > > Miscellaneous bug fixes related to ACPI to play nice with guest BIOSes/OSes > by conforming to ACPI spec better. > > Isaku Yamahata (3): > acpi/core: always set SCI_EN when SMM isn't supported > acpi: set fadt.smi_cmd to zero when SMM is not supported > hw/i386: declare ACPI mother board resource for MMCONFIG region
These all look good, but break make check: acpi-test: Warning! DSDT binary file mismatch. Actual [aml:/tmp/aml-YLJ7X0], Expected [aml:tests/data/acpi/q35/DSDT]. See source file tests/qtest/bios-tables-test.c for instructions on how to update expected files. acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-2KJ7X0.dsl, aml:/tmp/aml-YLJ7X0], Expected [asl:/tmp/asl-U2R7X0.dsl, aml:tests/data/acpi/q35/DSDT]. ** ERROR:../qemu/tests/qtest/bios-tables-test.c:509:test_acpi_asl: assertion failed: (all_tables_match) ERROR qtest-i386/bios-tables-test - Bail out! ERROR:../qemu/tests/qtest/bios-tables-test.c:509:test_acpi_asl: assertion failed: (all_tables_match) make: *** [Makefile.mtest:1713: run-test-212] Error 1 Probably because you didn't update the expected files. Pls follow the process at the top of tests/qtest/bios-tables-test.c and make sure all tests pass. > Sean Christopherson (1): > i386: acpi: Don't build HPET ACPI entry if HPET is disabled > > hw/acpi/core.c | 11 ++- > hw/acpi/ich9.c | 2 +- > hw/acpi/piix4.c | 3 +- > hw/i386/acpi-build.c | 188 +++++++++++++++++++++++++++++++++++++++-- > hw/isa/vt82c686.c | 2 +- > include/hw/acpi/acpi.h | 4 +- > 6 files changed, 200 insertions(+), 10 deletions(-) > > -- > 2.17.1