On 2/2/21 9:59 AM, Kevin Wolf wrote: > size_to_str() can return a size like "4.24 MiB", with a single digit > integer part and two fractional digits. This is eight characters, but > commit b39847a5 changed the format string to only reserve seven > characters for the column. > > This can result in unaligned columns, which in turn changes the output of > iotests case 267 because exceeding the column size defeats the attempt > to filter the size out of the output (observed with the ppc64 emulator). > The resulting change is only a whitespace change, but since commit > f203080b this is enough for iotests to consider the test failed. > > Taking a character away from the tag name column and adding it to the VM > size column doesn't change anything in the common case (the tag name is > left justified, the VM size is right justified), but fixes this case. > > Fixes: b39847a50553b7679d6d7fefbe6a108a17aacf8d > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/qapi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
