On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> We want 64bit write-zeroes, and for this, convert all io functions to
> 64bit.
>
> We chose signed type, to be consistent with off_t (which is signed) and
> with possibility for signed return type (where negative value means
> error).
>
> Please refer to initial cover-letter
> https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg08723.html
> for more info.
>
> v4: I found, that some more work is needed for block/block-backend, so
> decided to make partI, converting block/io
>
> v4 is based on Kevin's block branch ([PULL 00/34] Block layer patches)
> for BDRV_MAX_LENGTH
>
> changes:
> 01-05: new
> 06: add Alberto's r-b
> 07: new
> 08-16: rebase, add new-style request check, improve commit-msg, drop r-bs
I had planned to send a pull request for this series today, but ran into
a snag. Without this series applied, './check -qcow2' fails 030, 185,
and 297. With it applied, I now also get a failure in 206. I'm trying
to bisect which patch caused the problem, but here's the failure:
206 fail [20:54:54] [20:55:01] 6.9s (last: 6.7s) output
mismatch (see 206.out.bad)
--- /home/eblake/qemu/tests/qemu-iotests/206.out
+++ 206.out.bad
@@ -180,7 +180,7 @@
{"execute": "blockdev-create", "arguments": {"job-id": "job0",
"options": {"driver": "qcow2", "file": "node0", "size":
9223372036854775296}}}
{"return": {}}
-Job failed: Could not resize image: Required too big image size, it
must be not greater than 9223372035781033984
+Job failed: Could not resize image: offset(9223372036854775296) exceeds
maximum(9223372035781033984)
{"execute": "job-dismiss", "arguments": {"id": "job0"}}
{"return": {}}
Looks like it is just a changed error message, so I can touch up the
correct patch and then repackage the pull request tomorrow (it's too
late for me today). Oh, and the 0 exit status of ./check when a test
fails is something I see you already plan on fixing...
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
