On Fri, Jan 29, 2021 at 01:03:09PM +0100, Greg Kurz wrote: > On Tue, 26 Jan 2021 13:33:36 -0500 > Vivek Goyal <vgo...@redhat.com> wrote: > > [...] > > > > > > > Also, since pthread_rwlock_wrlock() can fail, I think we should > > > always check it's return value, at least with an assert() like > > > already done elsewhere. > > > > Will check return code of pthread_rwlock_wrlock() and probably use > > assert(). > > > > It turns out that pthread_rwlock_rdlock() and pthread_rwlock_unlock() can > also fail for various reasons that would likely indicate a programming > error, but their return values are never checked anywhere. > > I have a patch to address this globally in this file. Should I post it > now or you prefer this series goes first ?
Please go ahead and post your patch. Your patch can go first and I can rebase my patches on top of yours. Vivek
