On 1/28/21 6:21 PM, Stefan Weil wrote: > gcc (Debian 10.2.1-6) 10.2.1 20210110 aborts builds with enabled sanitizers: > > ../../../target/rx/op_helper.c: In function ‘helper_scmpu’: > ../../../target/rx/op_helper.c:213:24: error: ‘tmp1’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > 213 | env->psw_c = (tmp0 >= tmp1); > | ~~~~~~^~~~~~~~ > ../../../target/rx/op_helper.c:213:24: error: ‘tmp0’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > ../../../target/rx/op_helper.c: In function ‘helper_suntil’: > ../../../target/rx/op_helper.c:299:23: error: ‘tmp’ may be used uninitialized > in this function [-Werror=maybe-uninitialized] > 299 | env->psw_c = (tmp <= env->regs[2]); > | ~~~~~^~~~~~~~~~~~~~~~ > ../../../target/rx/op_helper.c: In function ‘helper_swhile’: > ../../../target/rx/op_helper.c:318:23: error: ‘tmp’ may be used uninitialized > in this function [-Werror=maybe-uninitialized] > 318 | env->psw_c = (tmp <= env->regs[2]); > | ~~~~~^~~~~~~~~~~~~~~~ > > Rewriting the code fixes those errors. > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > > Those error are false positives, but simple code changes help the > compiler (and perhaps reviewers) to understand it better. > > Stefan > > > target/rx/op_helper.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
