On 1/21/21 8:06 PM, Peter Maydell wrote: > Switch the CMSDK APB dualtimer device over to using its Clock input; > the pclk-frq property is now ignored. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > hw/timer/cmsdk-apb-dualtimer.c | 42 ++++++++++++++++++++++++++++++---- > 1 file changed, 37 insertions(+), 5 deletions(-) ...
> @@ -454,8 +486,8 @@ static void cmsdk_apb_dualtimer_realize(DeviceState *dev, > Error **errp) > CMSDKAPBDualTimer *s = CMSDK_APB_DUALTIMER(dev); > int i; > > - if (s->pclk_frq == 0) { > - error_setg(errp, "CMSDK APB timer: pclk-frq property must be set"); > + if (!clock_has_source(s->timclk)) { > + error_setg(errp, "CMSDK APB dualtimer: TIMCLK clock must be > connected"); > return; > } Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>