On 1/26/21 5:09 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé <phi...@redhat.com> writes: > >> On 1/26/21 3:57 PM, Alex Bennée wrote: >>> >>> Philippe Mathieu-Daudé <phi...@redhat.com> writes: >>> >>>> In this series we deselect a bunch of features when they >>>> not required, so less objects are built. >>>> >>>> While this reduce pressure on CI and slow systems, this is >>>> particularly helpful for developers regularly testing multiple >>>> build configurations. >>>> >>>> All CI tests pass: >>>> https://gitlab.com/philmd/qemu/-/pipelines/245654160 >>>> >>>> Supersedes: <20210120151916.1167448-1-phi...@redhat.com> >>> >>> Series looks good to me but I guess you need some sub-system feedback. >> >> Yeah, I will wait for Markus feedback on qapi/ before respining (with >> target/ fix), ... > > Maybe I'm naive today, but to me this looks like a case of "if it still > builds, it's fine". > > Anything in particular you want my feedback for?
You are listed as qapi/ maintainer with Michael :) QAPI M: Markus Armbruster <arm...@redhat.com> M: Michael Roth <michael.r...@amd.com> S: Supported F: qapi/ If it is fine to you, then I'll respin addressing Paolo's comments. Thanks :) Phil.
