On 1/21/21 2:23 AM, dje--- via wrote: > Signed-off-by: Doug Evans <d...@google.com> > ---
Rather light on the commit message description. The one-line summary does a good job of saying "what" the commit does, but the rest of the commit body should say "why" the commit is worthwhile, rather than being silent. > hmp-commands.hx | 29 ++++- > include/net/slirp.h | 2 + > net/slirp.c | 311 +++++++++++++++++++++++++++++++++++--------- > qapi/net.json | 1 + > slirp | 2 +- > 5 files changed, 279 insertions(+), 66 deletions(-) > > +++ b/qapi/net.json > @@ -189,6 +189,7 @@ > '*smb': 'str', > '*smbserver': 'str', > '*hostfwd': ['String'], > + '*ipv6-hostfwd': ['String'], Missing documentation, including a 'since 6.0' tag on the new member. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
