On 1/21/21 8:06 PM, Peter Maydell wrote: > The old-style convenience function cmsdk_apb_timer_create() for > creating CMSDK_APB_TIMER objects is used in only two places in > mps2.c. Most of the rest of the code in that file uses the new > "initialize in place" coding style. > > We want to connect up a Clock object which should be done between the > object creation and realization; rather than adding a Clock* argument > to the convenience function, convert the timer creation code in > mps2.c to the same style as is used already for the watchdog, > dualtimer and other devices, and delete the now-unused convenience > function. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > include/hw/timer/cmsdk-apb-timer.h | 21 --------------------- > hw/arm/mps2.c | 18 ++++++++++++++++-- > 2 files changed, 16 insertions(+), 23 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
